[Fix] forbid-component-props: support JSXNamespacedName

See AriPerkkio/eslint-remote-tester#29 (comment)
jsx-eslint · Apr 8, 2021 · cbe99e0 · cbe99e0
1 parent 2f376e0
commit cbe99e0
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,7 +8,8 @@ This change log adheres to standards from [Keep a CHANGELOG](http://keepachangel
 ### Fixed
 * [`jsx-max-depth`]: Prevent getting stuck in circular references ([#2957][] @AriPerkkio)
 * [`jsx-no-target-blank`]: fix handling of `warnOnSpreadAttributes` being false ([#2953][] @Nokel81)
-* [`forbid-dom-props`]: support `JSXNamespacedName` [#2961][] @mrtnzlml)
+* [`forbid-dom-props`]: support `JSXNamespacedName` ([#2961][] @mrtnzlml)
+* [`forbid-component-props`]: support `JSXNamespacedName` (@ljharb)
 
 ### Changed
 * Fix CHANGELOG.md ([#2950][] @JounQin)

diff --git a/lib/rules/forbid-component-props.js b/lib/rules/forbid-component-props.js
@@ -86,7 +86,7 @@ module.exports = {
         // Extract a component name when using a "namespace", e.g. `<AntdLayout.Content />`.
         const tag = parentName.name || `${parentName.object.name}.${parentName.property.name}`;
         const componentName = parentName.name || parentName.property.name;
-        if (componentName && componentName[0] !== componentName[0].toUpperCase()) {
+        if (componentName && typeof componentName[0] === 'string' && componentName[0] !== componentName[0].toUpperCase()) {
           // This is a DOM node, not a Component, so exit.
           return;
         }

diff --git a/tests/lib/rules/forbid-component-props.js b/tests/lib/rules/forbid-component-props.js
@@ -111,6 +111,8 @@ ruleTester.run('forbid-component-props', rule, {
     options: [{
       forbid: [{propName: 'className', allowedFor: ['this.ReactModal']}]
     }]
+  }, {
+    code: '<fbt:param name="Total number of files" number={true} />'
   }],
 
   invalid: [{